Add RT700 basic environment support #79376

lucien-nxp · 2024-10-03T15:38:12Z

support gpio/uart function

zephyrbot · 2024-10-03T15:39:12Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`c42d70d`	zephyrproject-rtos/hal_nxp#444	zephyrproject-rtos/hal_nxp#444/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/nxp/common/Kconfig.flexspi_xip

soc/nxp/imxrt/Kconfig

soc/nxp/imxrt/imxrt7xx/Kconfig

danieldegrasse · 2024-10-03T19:35:57Z

boards/nxp/mimxrt700_evk/doc/index.rst

+high-performance numerical tasks such as audio and image processing and supports both fixed-point and
+floating-point operations.
+
+Note: Due to board isn't launched, the picture is blank


Maybe just don't include an image? I'm not aware of a requirement that we actually have one.

It was announced - maybe you can find a picture here: https://www.nxp.com/products/processors-and-microcontrollers/arm-microcontrollers/i-mx-rt-crossover-mcus/i-mx-rt700-crossover-mcu-with-arm-cortex-m33-npu-dsp-and-gpu-cores:i.MX-RT700

Only release RT700 soc, EVK board don't launch currently. We can't show the board picture currently.

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/doc/index.rst

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu1_defconfig

boards/nxp/mimxrt700_evk/Kconfig.defconfig

boards/nxp/mimxrt700_evk/doc/mimxrt700_evk.webp

boards/nxp/mimxrt700_evk/mimxrt700_evk-pinctrl.dtsi

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0_defconfig

nordicjm · 2024-10-04T08:11:31Z

soc/nxp/imxrt/Kconfig

+config XSPI_CONFIG_BLOCK_OFFSET
+	hex "XSPI config block offset"
+	default 0x0
+	help
+	  XSPI configuration block consists of parameters regarding specific
+	  flash devices including read command sequence, quad mode enablement
+	  sequence (optional), etc. The boot ROM expects XSPI configuration
+	  parameter to be presented in serial nor flash.


why is this not in dts?

Not addressed

Does this make sense for DTS? It is a software setting for the offset of the XSPI configuration block, which will then be used by the bootrom to configure the XSPI to interface with an external flash device and execute from it

soc/nxp/imxrt/imxrt7xx/Kconfig.soc

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

lucien-nxp · 2024-11-29T09:32:45Z

Hi @hakehuang ， Could you help test all the LPC and RT3 digitals platforms based on this PR? I have updated iocon driver and pin header file for RT700. Thank you.

hakehuang · 2024-12-02T06:22:09Z

Hi @hakehuang ， Could you help test all the LPC and RT3 digitals platforms based on this PR? I have updated iocon driver and pin header file for RT700. Thank you.

sure, I kick another round of testing, will feedback once done

@lucien-nxp

op 500 values of testsuite.keyword	Failed
tests/kernel/mem_protect/mem_protect/kernel.memory_protection	15
tests/kernel/mem_protect/userspace/kernel.memory_protection.userspace	1
tests/kernel/threads/thread_stack/kernel.threads.armv8m_mpu_stack_guard	1
tests/kernel/fatal/exception/kernel.common.stack_protection_armv8m_mpu_stack_guard	2
samples/userspace/prod_consumer/sample.userspace.prod_consumer	1
samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem	1

west.yml

nordicjm · 2024-12-03T15:35:31Z

soc/nxp/common/Kconfig.xspi_xip

+	string
+	prompt "Xspi drivers memory location"
+	default "RAM"
+	help
+	  Select the location to run the XSPI drivers when using
+	  the flash API.


seems like this should be choice options not a string

No, it should be string because it will be used in cmake files, need to specifies the name of the region

I'm not understanding this, the region? What region? What possible values can this Kconfig have and what does it do?

I think the reason this wasn't made a choice is because different platforms have a different set of options for where the flash drivers could be relocated to. IE M7 parts support relocating to ITCM, but M33 parts can only really relocate to the RAM region.

Maybe we could define the choice here, and make options like "ITCM" dependent on the SOC devicetree defining an ITCM devicetree node?

nordicjm · 2024-12-03T15:35:48Z

soc/nxp/imxrt/Kconfig

+config XSPI_CONFIG_BLOCK_OFFSET
+	hex "XSPI config block offset"
+	default 0x0
+	help
+	  XSPI configuration block consists of parameters regarding specific
+	  flash devices including read command sequence, quad mode enablement
+	  sequence (optional), etc. The boot ROM expects XSPI configuration
+	  parameter to be presented in serial nor flash.


Not addressed

soc/nxp/imxrt/imxrt7xx/CMakeLists.txt

boards/nxp/mimxrt700_evk/doc/index.rst

lucien-nxp · 2024-12-04T10:10:53Z

Hi @danieldegrasse ,
Could you help review the current iocon driver and pinctrl model on RT700? I have updated them according to the model you provide.

track rt700 sdk files update PR branch Signed-off-by: Lucien Zhao <[email protected]>

add rt7xx files related to soc support basic clock enablement add HAS_MCUX_XSPI/HAS_GLIKEY Kconfig add common/Kconfig.xspi_xip file Signed-off-by: Lucien Zhao <[email protected]>

add RT7xx dts files add iocon/gpio/flexcomm/clock instances in dts Signed-off-by: Lucien Zhao <[email protected]>

add nxp,imx-xspi-device.yaml add nxp,imx-xspi-mx25um51345g.yaml add nxp,imx-xspi.yaml Signed-off-by: Lucien Zhao <[email protected]>

add more flexcomm instances clock support to adapt rt700 instances number add xspi clock support Signed-off-by: Lucien Zhao <[email protected]>

Due to there is no port on RT7xx soc, update driver to adapt rt7xx pin mux model(Use IOPCTL_PinMuxSet function to configure pinmux set) Signed-off-by: Lucien Zhao <[email protected]>

update gpio driver to adapt rt7xx gpio model: 1. There is no PORT_Type on RT7xx,so set PORT_Type as void 2. Add port_no parameter in gpio_mcux_config to adapt IOPCTL driver 3. Add gpio-port-offest parameter in blinding, it will help map the relation between index n and gpio port when some soc have domain access attribution. 4. Add code to adapt RT700 GPIO attribute configuration Signed-off-by: Lucien Zhao <[email protected]>

add files related to mimxrt700_evk board add gpio/uart function support on board Signed-off-by: Lucien Zhao <[email protected]>

The number of mpu regions that can be configured is less than four cases. Therefore, only remove this case on cm33 cores, failed log show below: "num_parts of 4 exceeds maximum allowable partitions (3)" Signed-off-by: Lucien Zhao <[email protected]>

lucien-nxp · 2024-12-05T03:40:38Z

Hi @hakehuang ， Could you help test all the LPC and RT3 digitals platforms based on this PR? I have updated iocon driver and pin header file for RT700. Thank you.

sure, I kick another round of testing, will feedback once done

@lucien-nxp

op 500 values of testsuite.keyword Failed
tests/kernel/mem_protect/mem_protect/kernel.memory_protection 15
tests/kernel/mem_protect/userspace/kernel.memory_protection.userspace 1
tests/kernel/threads/thread_stack/kernel.threads.armv8m_mpu_stack_guard 1
tests/kernel/fatal/exception/kernel.common.stack_protection_armv8m_mpu_stack_guard 2
samples/userspace/prod_consumer/sample.userspace.prod_consumer 1
samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem 1

Hi Hake,
These issue seems is caused by limited MPU region available on cm33 core. I have updated the code and try most of them, and it have been passed on my local. Could you help re-test?

lucien-nxp · 2024-12-05T15:45:35Z

Hi @danieldegrasse , Could you help review the current iocon driver and pinctrl model on RT700? I have updated them according to the model you provide.

Hi @danieldegrasse , could you help review the current pinctrl model? Thank you.

danieldegrasse

IOCON driver changes generally look good, thank you for this update

danieldegrasse · 2024-12-05T16:45:02Z

west.yml

Nit on this commit message- please update to something like the following:

manifest: update hal_nxp revision

danieldegrasse · 2024-12-05T16:47:33Z

modules/Kconfig.mcux

@@ -394,4 +394,9 @@ config NXP_RF_IMU
 	help
 	   RF_IMU adapter is needed for intercore messaging.

+config HAS_GLIKEY


Is the GLIKEY something we could describe in the devicetree? The HAS_XXX Kconfigs are typically legacy Kconfigs from before we had the DT_HAS_xxx_ENABLED Kconfigs, which functionally replaced these

Currently, we can't describe it in dts, there is no driver supported. I will migrate Kconfig defined under rt7xx folder and modify the kconfig name to GLIKEY_MCUX_GLIKEY.

We can still have a devicetree node without a specific driver- for example, I've done this for PLL configurations within SOCs:

zephyr/soc/nxp/imxrt/imxrt10xx/soc.c

Line 45 in e60f040

const clock_sys_pll_config_t sysPllConfig = {

zephyr/dts/bindings/clock/nxp,imx-ccm-fnpll.yaml

Line 1 in e60f040

# Copyright 2024 NXP

danieldegrasse · 2024-12-05T16:47:59Z

soc/nxp/common/Kconfig.xspi_xip

+# SPDX-License-Identifier: Apache-2.0
+
+DT_CHOSEN_Z_FLASH := zephyr,flash
+DT_COMPAT_XSPI := nxp,imx-xspi


Let's avoid using imx in the compatible name- simply nxp,xspi would work

danieldegrasse · 2024-12-05T16:53:32Z

soc/nxp/common/Kconfig.xspi_xip

+	string
+	prompt "Xspi drivers memory location"
+	default "RAM"
+	help
+	  Select the location to run the XSPI drivers when using
+	  the flash API.


I think the reason this wasn't made a choice is because different platforms have a different set of options for where the flash drivers could be relocated to. IE M7 parts support relocating to ITCM, but M33 parts can only really relocate to the RAM region.

Maybe we could define the choice here, and make options like "ITCM" dependent on the SOC devicetree defining an ITCM devicetree node?

danieldegrasse · 2024-12-05T17:00:05Z

soc/nxp/imxrt/Kconfig

+config XSPI_CONFIG_BLOCK_OFFSET
+	hex "XSPI config block offset"
+	default 0x0
+	help
+	  XSPI configuration block consists of parameters regarding specific
+	  flash devices including read command sequence, quad mode enablement
+	  sequence (optional), etc. The boot ROM expects XSPI configuration
+	  parameter to be presented in serial nor flash.


Does this make sense for DTS? It is a software setting for the offset of the XSPI configuration block, which will then be used by the bootrom to configure the XSPI to interface with an external flash device and execute from it

danieldegrasse · 2024-12-05T17:07:44Z

drivers/pinctrl/pinctrl_lpc_iocon.c

Commit message here needs to be updated, IOPCTL_PinMuxSet function is not being used

danieldegrasse · 2024-12-05T17:10:28Z

drivers/pinctrl/pinctrl_lpc_iocon.c

@@ -11,22 +11,40 @@
 #include <fsl_clock.h>
 #endif

+/* IOCON register addresses. */
+static uint32_t *iocon[] = {


Suggested change

static uint32_t *iocon[] = {

static uint32_t *volatile iocon[] = {

I think the pointers in this array need to be declared as volatile still

danieldegrasse · 2024-12-05T17:11:27Z

drivers/pinctrl/pinctrl_lpc_iocon.c

 {
 	for (uint8_t i = 0; i < pin_cnt; i++) {
 		uint32_t pin_mux = pins[i];
 		uint32_t offset = OFFSET(pin_mux);
+		uint32_t index = INDEX(pin_mux);


No need to use uint32_t here, this can be a uint8_t based on mask width, right?

danieldegrasse · 2024-12-05T17:15:40Z

drivers/gpio/gpio_mcux.c

 {
 	const struct gpio_mcux_config *config = dev->config;
 	GPIO_Type *gpio_base = config->gpio_base;
+
+#if defined(CONFIG_PINCTRL_NXP_IOCON)


Perhaps rather than doing all this #ifdef'ery, could we split the pin control settings into two functions?

gpio_mcux_port_configure

gpio_mcux_iopctl_configure

Then we could simply have one ifdef in this function, and call the correct helper

danieldegrasse · 2024-12-05T17:19:21Z

drivers/gpio/gpio_mcux.c

-									\
-	static int gpio_mcux_port## n ##_init(const struct device *dev)	\
-	{								\
+#define GPIO_PORT_NUMBER(n) COND_CODE_1(DT_INST_NODE_HAS_PROP(n, gpio_port_offest),	\


If possible splitting the formatting changes here (which seem to be from running clang-format) out from the functional changes to the driver would make this easier to review. If not, just be aware that is best practice in the future (not to mix formatting changes and functional ones in the same commit)

kartben · 2024-12-06T03:38:04Z

boards/nxp/mimxrt700_evk/doc/index.rst

+.. _mimxrt700_evk:
+
+NXP MIMXRT700-EVK
+##################


Please check board template (i.e. use zephyr:board directive here) and set full_name in the board.yml (you may look at how it's done for other NXP boards)

Also consider including an image for the board

lucien-nxp requested review from mmahadevan108 and dleach02 as code owners October 3, 2024 15:38

zephyrbot added area: Clock Control area: GPIO platform: NXP NXP area: Pinctrl platform: NXP Drivers NXP Semiconductors, drivers labels Oct 3, 2024

zephyrbot requested review from butok, danieldegrasse, dbaluta, decsny, DerekSnell, EmilioCBen, gmarull, henrikbrixandersen, manuargue, MarkWangChinese, mnkp, nordic-krch and yvanderv October 3, 2024 15:39

zephyrbot assigned dleach02 and mmahadevan108 Oct 3, 2024

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 3, 2024

lucien-nxp force-pushed the add_rt700_baseline_support branch from aebb39a to a8fc58d Compare October 3, 2024 16:42

danieldegrasse reviewed Oct 3, 2024

View reviewed changes

nordicjm requested changes Oct 4, 2024

View reviewed changes

butok reviewed Oct 4, 2024

View reviewed changes

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts Outdated Show resolved Hide resolved

lucien-nxp force-pushed the add_rt700_baseline_support branch 2 times, most recently from 2334439 to 59930f1 Compare December 3, 2024 02:59

lucien-nxp requested review from decsny, DerekSnell, Raymond0225, nordicjm, danieldegrasse, butok and dbaluta December 3, 2024 15:29

nordicjm requested changes Dec 3, 2024

View reviewed changes

lucien-nxp force-pushed the add_rt700_baseline_support branch from 59930f1 to f727098 Compare December 5, 2024 03:13

zephyrbot added area: Userspace Userspace area: Samples Samples labels Dec 5, 2024

lucien-nxp added 9 commits December 5, 2024 11:33

manifest: update west.yml

12e9fd7

track rt700 sdk files update PR branch Signed-off-by: Lucien Zhao <[email protected]>

soc: nxp: imxrt: imxrt7xx: add rt7xx soc files

608f091

add rt7xx files related to soc support basic clock enablement add HAS_MCUX_XSPI/HAS_GLIKEY Kconfig add common/Kconfig.xspi_xip file Signed-off-by: Lucien Zhao <[email protected]>

dts: arm: nxp: add RT7xx dts files

34691de

add RT7xx dts files add iocon/gpio/flexcomm/clock instances in dts Signed-off-by: Lucien Zhao <[email protected]>

dts: bindings: add the first version binding for nxp,imx-xspi IP

43b8819

add nxp,imx-xspi-device.yaml add nxp,imx-xspi-mx25um51345g.yaml add nxp,imx-xspi.yaml Signed-off-by: Lucien Zhao <[email protected]>

drivers: clock_control: update mcux_lpc_syscon_clock.c drivers

5638d8a

add more flexcomm instances clock support to adapt rt700 instances number add xspi clock support Signed-off-by: Lucien Zhao <[email protected]>

drivers: pinctrl: update pinctrl_lpc_iocon.c driver

33b0756

Due to there is no port on RT7xx soc, update driver to adapt rt7xx pin mux model(Use IOPCTL_PinMuxSet function to configure pinmux set) Signed-off-by: Lucien Zhao <[email protected]>

boards: nxp: add mimxrt700_evk board

88cd7c1

add files related to mimxrt700_evk board add gpio/uart function support on board Signed-off-by: Lucien Zhao <[email protected]>

lucien-nxp force-pushed the add_rt700_baseline_support branch from f727098 to 49c18a5 Compare December 5, 2024 03:33

danieldegrasse reviewed Dec 5, 2024

View reviewed changes

kartben requested changes Dec 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RT700 basic environment support #79376

Add RT700 basic environment support #79376

lucien-nxp commented Oct 3, 2024

zephyrbot commented Oct 3, 2024 •

edited

Loading

danieldegrasse Oct 3, 2024

iuliana-prodan Oct 4, 2024

lucien-nxp Oct 16, 2024

nordicjm Oct 4, 2024

nordicjm Dec 3, 2024

danieldegrasse Dec 5, 2024

lucien-nxp commented Nov 29, 2024

hakehuang commented Dec 2, 2024 •

edited

Loading

nordicjm Dec 3, 2024

lucien-nxp Dec 5, 2024

nordicjm Dec 5, 2024

danieldegrasse Dec 5, 2024

nordicjm Dec 3, 2024

lucien-nxp commented Dec 4, 2024

lucien-nxp commented Dec 5, 2024

lucien-nxp commented Dec 5, 2024

danieldegrasse left a comment

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

lucien-nxp Dec 6, 2024

danieldegrasse Dec 6, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

danieldegrasse Dec 5, 2024

kartben Dec 6, 2024

	static uint32_t *iocon[] = {
	static uint32_t *volatile iocon[] = {

Add RT700 basic environment support #79376

Are you sure you want to change the base?

Add RT700 basic environment support #79376

Conversation

lucien-nxp commented Oct 3, 2024

zephyrbot commented Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucien-nxp commented Nov 29, 2024

hakehuang commented Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucien-nxp commented Dec 4, 2024

lucien-nxp commented Dec 5, 2024

lucien-nxp commented Dec 5, 2024

danieldegrasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zephyrbot commented Oct 3, 2024 •

edited

Loading

hakehuang commented Dec 2, 2024 •

edited

Loading